feat: bundle esm + cjs variants of runtime packages using tsdown#452
Merged
feat: bundle esm + cjs variants of runtime packages using tsdown#452
Conversation
mnahkies
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adopts the use of https://tsdown.dev/ to bundle the runtime packages as distinct CJS and ESM distributions.
increasingly, we've run into issues where mixing and matching ESM/CJS creates annoying build errors, such as the
axiostype-mismatches between their CJS and ESM typings that we had to patch out.similar issues occurred whilst updating
@koa/routerto v15, and so decided it was time to address.the primary downside, is that the
distfiles will no longer mirror thesrcstructure.this will require careful testing of package publishing and installation to ensure there are no regressions prior to release.